Fix text-area scroll with fixed height in material theme #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
niiyeboah
force-pushed
the
fix/text-area-scroll-material#310
branch
from
cbd463e
to
4710d0b
Compare
|
With this fix the error label is displayed above the material line when it should be under it.
|
niiyeboah
force-pushed
the
fix/text-area-scroll-material#310
branch
2 times, most recently
from
af71224
to
c0d4a13
Compare
web-padawan
requested changes
Feb 26, 2019
|
This could probably be fixed by moving the underline from |
That will cause the same issue shown in the screenshot @samiheikki posted. The red underline is underneath the error message. |
niiyeboah
force-pushed
the
fix/text-area-scroll-material#310
branch
from
c0d4a13
to
2712ac4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #310
This change is